Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new code generator API for LLVM backend. #413

Merged
merged 19 commits into from
May 9, 2019
Merged

Use the new code generator API for LLVM backend. #413

merged 19 commits into from
May 9, 2019

Conversation

losfair
Copy link
Contributor

@losfair losfair commented May 1, 2019

No description provided.

@bjfish
Copy link
Contributor

bjfish commented May 4, 2019

bors try

@bors
Copy link
Contributor

bors bot commented May 4, 2019

try

Merge conflict

@bjfish
Copy link
Contributor

bjfish commented May 5, 2019

bors try

bors bot added a commit that referenced this pull request May 5, 2019
@bors
Try #413:
3881368
@bors
Copy link
Contributor

bors bot commented May 5, 2019

try

Build failed

@bjfish
Copy link
Contributor

bjfish commented May 5, 2019

bors try

bors bot added a commit that referenced this pull request May 5, 2019
@bors
Try #413:
e6ebbae
@bors
Copy link
Contributor

bors bot commented May 5, 2019

try

Build succeeded

@bjfish
Copy link
Contributor

bjfish commented May 6, 2019

bors try

bors bot added a commit that referenced this pull request May 6, 2019
@bors
Try #413:
07192bf
@bors
Copy link
Contributor

bors bot commented May 6, 2019

try

Build succeeded

@bjfish
Copy link
Contributor

bjfish commented May 7, 2019

bors try

@bors
Copy link
Contributor

bors bot commented May 7, 2019

try

Timed out

@bjfish
Copy link
Contributor

bjfish commented May 7, 2019

bors try

bors bot added a commit that referenced this pull request May 7, 2019
@bors
Try #413:
166e9e8
@bjfish
Copy link
Contributor

bjfish commented May 7, 2019

bors cancel

@bjfish bjfish marked this pull request as ready for review May 7, 2019 15:16
@bjfish
Copy link
Contributor

bjfish commented May 7, 2019

bors try

@bors
Copy link
Contributor

bors bot commented May 7, 2019

try

Already running a review

@bors
Copy link
Contributor

bors bot commented May 7, 2019

try

Build succeeded

@xmclark xmclark self-requested a review May 7, 2019 15:56
xmclark
xmclark suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@xmclark xmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback. I am missing context on this PR, so I don't have much yet.

lib/llvm-backend/src/code.rs Outdated Show resolved Hide resolved
lib/llvm-backend/src/code.rs Show resolved Hide resolved
@bjfish
Copy link
Contributor

bjfish commented May 8, 2019

bors try

bors bot added a commit that referenced this pull request May 8, 2019
@bors
Try #413:
bdd0b43
@bors
Copy link
Contributor

bors bot commented May 8, 2019

try

Build succeeded

syrusakbary
syrusakbary approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at this few times to make sure I understand properly the changes.

Everything looks good, but I would love to see more docs. Maybe we can address this in a different PR though :)

@bjfish
Copy link
Contributor

bjfish commented May 9, 2019

bors r+

1 similar comment
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request May 9, 2019
@bors @bjfish @losfair
Merge #413
7f61eaf 
413: Use the new code generator API for LLVM backend. r=syrusakbary a=losfair



Co-authored-by: Brandon Fish <[email protected]>
Co-authored-by: losfair <[email protected]>
Co-authored-by: Brandon Fish <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 9, 2019

Build succeeded

@bors bors bot merged commit 080220c into master May 9, 2019
@bors bors bot deleted the feature/llvm-cgapi branch May 9, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjfish bjfish bjfish left review comments

@xmclark xmclark xmclark requested changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees

@bjfish bjfish

@losfair losfair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@losfair @bjfish @syrusakbary @xmclark